Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Actions Utility Methods #1799

Closed
benjchristensen opened this issue Oct 24, 2014 · 1 comment
Closed

Remove Actions Utility Methods #1799

benjchristensen opened this issue Oct 24, 2014 · 1 comment
Milestone

Comments

@benjchristensen
Copy link
Member

Related to #1797 it looks like we should remove the following unused methods in Actions:

    public static <T> Action1<T> onNextFrom(final Observer<T> observer) {
    public static <T> Action1<Throwable> onErrorFrom(final Observer<T> observer) {
    public static <T> Action1<T> onNextFrom(final Observer<T> observer) {
@akarnokd
Copy link
Member

I added them to support the join patterns but only onErrorFrom was ever used. They can be deleted from core but onErrorFrom needs to be moved over and actualized in Plan1...PlanN.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants