RxScala: Add mapping to RxJava doOnUnsubscribe #1598
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
RxJava-pull-requests #1504 FAILURE |
| * </dl> | ||
| * | ||
| * @param onUnsubscribe the action that gets called when this { @code Observable} is unsubscribed | ||
| * @return the source { @code Observable} modified so as to call this Action when appropriate |
There was a problem hiding this comment.
{ @code Observable} and {@link Scheduler} are invalid in scaladoc. You can use markdown syntax, such as Observable, or [[Observable]].
- Fix doOnUnsubscribe JavaDoc to not use @code/@link
|
RxJava-pull-requests #1506 SUCCESS |
|
LGTM |
benjchristensen
added a commit
that referenced
this pull request
Aug 18, 2014
RxScala: Add mapping to RxJava doOnUnsubscribe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.