Fix the compose generics #1701
Merged
Fix the compose generics #1701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @SuppressWarnings("unchecked") | ||
| public <R> Observable<R> compose(Transformer<? super T, ? extends R> transformer) { | ||
| // Casting to Observable<R> is type-safe because we know Observable is covariant. | ||
| return (Observable<R>) transformer.call(this); |
There was a problem hiding this comment.
Ah interesting. This never worked for me, so you're just doing it via a cast and forcing it.
|
Thank you @zsxwing ... I guess one of @headinthebox or I owes you a drink! Now to figure out how to get to you in China. |
benjchristensen
added a commit
that referenced
this pull request
Oct 2, 2014
Fix the compose generics
Merged
|
Buy one when you get a chance to visit China or when I visit Bay Area :) |
|
Sounds good. I'd love to get to China at some point. Thanks again. |
This was referenced Oct 4, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.