Skip to content

Fixed retry without backpressure & test function to support bp. #1912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 1, 2014
Merged

Fixed retry without backpressure & test function to support bp. #1912

merged 1 commit into from
Dec 1, 2014

Conversation

akarnokd
Copy link
Member

@akarnokd akarnokd commented Dec 1, 2014

Fixes include:

  • do not decrement the client capacity if it is unbounded,
  • do not request 0,
  • propagate request count (n) instead of capacity + request (c + n),
  • FuncWithErrors to support backpressure; there was a non-zero chance the final succeding pair of onNexts would trigger a MissingBackpressureException.

benjchristensen added a commit that referenced this pull request Dec 1, 2014
@benjchristensen
Merge pull request #1912 from akarnokd/RetryWithBackpressureFix
f46d7f9 
Fixed retry without backpressure & test function to support bp.
@benjchristensen benjchristensen merged commit f46d7f9 into ReactiveX:1.x Dec 1, 2014
@akarnokd akarnokd deleted the RetryWithBackpressureFix branch December 9, 2014 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akarnokd @benjchristensen