Subscriber.request should throw exception if negative request made #2548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the IAE should be mentioned in request's javadoc. |
davidmoten
force-pushed
the
request-check
branch
from
a780dfd to
8fd09fb
Compare
|
javadoc added |
|
Great! |
akarnokd
added a commit
that referenced
this pull request
Jan 28, 2015
Subscriber.request should throw exception if negative request made
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per discussion in #1956 and #2545, making a call to
Subscriber.request(n)with negative n should throw anIllegalArgumentException.Includes unit test.