prevent take() from requesting more than needed #2989
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // ensure we only request as much as needed, no more no less | ||
| while (true) { | ||
| long r = requested.get(); | ||
| long c = Math.min(n, limit - requested.get()); |
There was a problem hiding this comment.
Re-read of a volatile value, you need limit - r.
davidmoten
force-pushed
the
take-request-bug
branch
from
ab96a98 to
85a035d
Compare
|
Thanks @akarnokd. Changes made. |
|
Great job! |
akarnokd
added a commit
that referenced
this pull request
May 29, 2015
prevent take() from requesting more than needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
requestmethod used logic that could overrequest upstream if multiple small requests were made before the next item arrived.Added a unit test that failed on previous code.