Add Single.doOnSuccess() #3417
Add Single.doOnSuccess() #3417
Conversation
artem-zinnatullin
force-pushed
the
single-do-on-success
branch
from
bfb1ee7
to
7d73e2c
Compare
| testSubscriber.assertError(error); | ||
|
|
||
| verifyZeroInteractions(action); | ||
| } |
There was a problem hiding this comment.
Could you also test what happens if the action callback throws?
There was a problem hiding this comment.
See doOnSuccessShouldNotSwallowExceptionThrownByAction()
| * @return the source {@link Single} with the side-effecting behavior applied | ||
| * @see <a href="http://reactivex.io/documentation/operators/do.html">ReactiveX operators documentation: Do</a> | ||
| */ | ||
| public final Single<T> doOnSuccess(final Action1<? super T> onSuccess) { |
There was a problem hiding this comment.
This should start out as experimental unless the RxJava contributors want to fast-track this.
There was a problem hiding this comment.
I didn't add @Experimental here and in the other PRs because whole class Single is marked with @Experimental. Do you think we should mark these basic operators too?
There was a problem hiding this comment.
Yep, this is a bit of a conflict because #3401 gets merged first, this would also become beta without any votes.
There was a problem hiding this comment.
Okay, no problem. I'll mark it as @experimental.
чт, 8 Окт 2015, 12:44, David Karnok notifications@github.com:
In src/main/java/rx/Single.java
#3417 (comment):@@ -1789,4 +1790,36 @@ public void onNext(T t) {
return zip(this, other, zipFunction);
}
- /**
\* Modifies the source {@link Single} so that it invokes an action when it calls {@code onSuccess}.\* <p>\* <img width="640" height="310" src="https://raw.github.com/wiki/ReactiveX/RxJava/images/rx-operators/doOnNext.png" alt="">\* <dl>\* <dt><b>Scheduler:</b></dt>\* <dd>{@code doOnSuccess} does not operate by default on a particular {@link Scheduler}.</dd>\* </dl>*\* @param onSuccess\* the action to invoke when the source {@link Single} calls {@code onSuccess}\* @return the source {@link Single} with the side-effecting behavior applied\* @see <a href="http://reactivex.io/documentation/operators/do.html">ReactiveX operators documentation: Do</a>*/- public final Single doOnSuccess(final Action1<? super T> onSuccess) {
Yep, this is a bit of a conflict because #3401
#3401 gets merged first, this
would also become beta without any votes.—
Reply to this email directly or view it on GitHub
https://github.com/ReactiveX/RxJava/pull/3417/files#r41494676.
@artem_zin
There was a problem hiding this comment.
Added @Experimental
artem-zinnatullin
force-pushed
the
single-do-on-success
branch
from
7d73e2c
to
4249c6a
Compare
|
👍 |
|
@artem-zinnatullin rebase please. |
artem-zinnatullin
force-pushed
the
single-do-on-success
branch
from
4249c6a
to
0c0a18f
Compare
|
@abersnaze rebased! |
Closes #3385.