1.x: add never test for PublishSubjectTest

[Chaoba]

This PR complete the never assert in PublishSubjectTest.

[JakeWharton]

I think you'll want verifyNoMoreInteractions(observer) to end these two methods, otherwise sending an onNext of "five" would not fail the test.

[akarnokd]

👍

[vanniktech]

In every test method that is using verifyNoMoreInteractions you can remove the verify(observer, never()).*

[Chaoba]

In every test method that is using verifyNoMoreInteractions you can remove the verify(observer, never()).*

Your are right, but I think adding these verifies can make tests more clearly.

[vanniktech]

Fair enough. I just thought you forgot to delete them and wanted to point it out.
In any case the deletion decision is something the repo owners have to do.

Personally the less test code the preciser it is. Especially since verifyNoMoreInteractions clearly states it purpose.

[zsxwing]

👍

[stevegury]

👍