Update javadoc for Subscribers.empty() #3665
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * {@code EmptyObserver} will swallow the error in such a case). | ||
| * Returns an inert {@link Subscriber} that does nothing in response to the emissions or notifications | ||
| * from any {@code Observable} it subscribes to. Will throw an exception if {@link Subscriber#onError onError} | ||
| * method is called |
There was a problem hiding this comment.
Could also add the exception name in the doc, like Will throw an {@link OnErrorNotImplementedException} ...
|
👍 |
1 similar comment
|
👍 |
|
I'll squash in a few when I get to work.
|
|
👍 |
1 similar comment
|
👍 |
akarnokd
added a commit
that referenced
this pull request
Feb 3, 2016
Update javadoc for Subscribers.empty()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for #3664