1.x: Fix Observable delay methods typos in documenation #3791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great, thanks! 👍 |
akarnokd
changed the title
|
👍 |
|
@neoranga55 there's also one here |
|
@vanniktech do you suggest adding the fix for Single to this current PR or opening a new one? |
|
Maybe its easier to search for that typo in all files and fix them in a single PR. |
|
@akarnokd that's exactly what I did |
|
Okay, to be clear, please fix the type on Single as well in this PR. |
|
Ok, added the fix for Single, I'm not familiar with the branching flow here so I did the one I'm familiar with: rebase to collapse both changes into a single commit. |
|
Looking good now 👍 |
|
We prefer single commit PRs so you did right by squashing the commits. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.