Skip to content

2.x: coverage and cleanup 10/04-1 #4666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2016
Merged

Conversation

akarnokd
Copy link
Member

@akarnokd akarnokd commented Oct 4, 2016

  • Improve coverage
  • remove unused, unnecessary or impossible code paths
  • fix order of inner exceptions in the reported CompositeException in various operators
  • Maybe.ignoreElement() now returns Completable

@codecov-io
Copy link

codecov-io commented Oct 4, 2016

Current coverage is 82.31% (diff: 77.19%)

Merging #4666 into 2.x will increase coverage by 1.21%

@@                2.x      #4666   diff @@
==========================================
  Files           556        557     +1   
  Lines         36420      36402    -18   
  Methods           0          0          
  Messages          0          0          
  Branches       5576       5568     -8   
==========================================
+ Hits          29539      29965   +426   
+ Misses         4869       4438   -431   
+ Partials       2012       1999    -13   

Powered by Codecov. Last update df94c0d...247b6c7

* called by the source Maybe
* @see <a href="http://reactivex.io/documentation/operators/ignoreelements.html">ReactiveX operators documentation: IgnoreElements</a>
*/
@SchedulerSupport(SchedulerSupport.NONE)
public final Maybe<T> ignoreElement() {
return RxJavaPlugins.onAssembly(new MaybeIgnoreElement<T>(this));
public final Completable ignoreElement() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@akarnokd akarnokd merged commit 23a77e8 into ReactiveX:2.x Oct 4, 2016
@akarnokd akarnokd deleted the Cleanup_1004_1 branch October 4, 2016 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants