2.x: add Flowable.doAfterNext operator + 3 doX TCKs
#4833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 95.73% (diff: 100%)@@ 2.x #4833 diff @@
==========================================
Files 576 577 +1
Lines 37048 37093 +45
Methods 0 0
Messages 0 0
Branches 5591 5596 +5
==========================================
+ Hits 35459 35512 +53
+ Misses 660 654 -6
+ Partials 929 927 -2
|
JakeWharton
approved these changes
Nov 10, 2016
| @Override | ||
| public Publisher<Integer> createPublisher(long elements) { | ||
| return FlowableTck.wrap( | ||
| Flowable.range(0, (int)elements).doOnNext(Functions.emptyConsumer()) |
There was a problem hiding this comment.
I don't really understand the purpose of these three tests. If the side-effecting operator just swallows the event it's not really validating anything.
There was a problem hiding this comment.
These test verify that the operators and the chain still honors the RS specification. The regular JUnit test verify if the operator does what it supposed to do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
Flowable.doAfterNextoperator which calls aConsumerafter the call todownstream.onNext()with the same value.In addition,
doOnNext,doAfterNextanddoFinallyreceived their Reactive-Streams TCK tests.