2.x: fix LambdaObserver calling dispose when terminating #4957

Merged
merged 1 commit into from Jan 4, 2017

Projects

None yet

3 participants

@akarnokd
Member
akarnokd commented Jan 4, 2017

This PR changes the LambdaObserver to not dispose the upstream when it receives a terminal event. The LambdaSubscriber has been previoulsy updated but apparently not synced.

Reported in #4956.

This PR fixes 2 unit test methods of Flowable.ignoreElements() as they were not actually testing the operator (discovered when the Observable.ignoreElements() initially failed after the patch to LambdaObserver).

@akarnokd akarnokd added 2.x Bug labels Jan 4, 2017
@akarnokd akarnokd added this to the 2.0 backlog milestone Jan 4, 2017
@codecov-io
codecov-io commented Jan 4, 2017 edited

Current coverage is 95.68% (diff: 100%)

Merging #4957 into 2.x will decrease coverage by 0.05%

@@                2.x      #4957   diff @@
==========================================
  Files           587        587          
  Lines         37551      37551          
  Methods           0          0          
  Messages          0          0          
  Branches       5655       5655          
==========================================
- Hits          35950      35929    -21   
- Misses          676        685     +9   
- Partials        925        937    +12   

Powered by Codecov. Last update 19fac95...f7287ce

@akarnokd akarnokd merged commit 479f89f into ReactiveX:2.x Jan 4, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@akarnokd akarnokd deleted the akarnokd:DoFinallyOrder branch Jan 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment