2.x: fix withLatestFrom null checks, lifecycle #4970

Merged
merged 1 commit into from Jan 8, 2017

Projects

None yet

4 participants

@akarnokd
Member
akarnokd commented Jan 8, 2017

This PR fixes the lack of null check on the result of the combiner function as well as fixes the lifecycle of the FlowableWithLatestFrom to avoid races with the onSubscribe.

@akarnokd akarnokd added 2.x Bug labels Jan 8, 2017
@akarnokd akarnokd added this to the 2.0 backlog milestone Jan 8, 2017
@codecov-io
codecov-io commented Jan 8, 2017 edited

Current coverage is 95.58% (diff: 100%)

Merging #4970 into 2.x will increase coverage by 0.05%

@@                2.x      #4970   diff @@
==========================================
  Files           591        591          
  Lines         37959      37956     -3   
  Methods           0          0          
  Messages          0          0          
  Branches       5756       5753     -3   
==========================================
+ Hits          36264      36282    +18   
+ Misses          721        712     -9   
+ Partials        974        962    -12   

Powered by Codecov. Last update d173b6d...29037ba

@hzsweers

LGTM

@akarnokd akarnokd merged commit 307a6a6 into ReactiveX:2.x Jan 8, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@akarnokd akarnokd deleted the akarnokd:WithLatestFromNullCheck branch Jan 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment