Skip to content

2.x: Readme.md update snapshot links #5645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 5, 2017

Conversation

akarnokd
Copy link
Member

@akarnokd akarnokd commented Oct 4, 2017

Update the snapshot link to the upcoming 2.1.5+ and 2.2.x versions. Also I've added a convenience link to the actual directory listing of the various snapshots hosted by JFrog.

@akarnokd akarnokd added this to the 2.2 milestone Oct 4, 2017
@codecov
Copy link

codecov bot commented Oct 4, 2017

Codecov Report

Merging #5645 into 2.x will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #5645      +/-   ##
============================================
+ Coverage     96.18%   96.25%   +0.06%     
- Complexity     5846     5849       +3     
============================================
  Files           634      634              
  Lines         41539    41539              
  Branches       5752     5752              
============================================
+ Hits          39956    39985      +29     
+ Misses          628      613      -15     
+ Partials        955      941      -14
Impacted Files Coverage Δ Complexity Δ
...rnal/operators/observable/ObservableObserveOn.java 97.95% <0%> (-2.05%) 3% <0%> (ø)
.../internal/disposables/ListCompositeDisposable.java 98% <0%> (-2%) 34% <0%> (-1%)
...l/operators/observable/ObservableFlatMapMaybe.java 90.19% <0%> (-1.97%) 2% <0%> (ø)
...internal/operators/completable/CompletableAmb.java 98.3% <0%> (-1.7%) 11% <0%> (ø)
...ternal/operators/completable/CompletableMerge.java 96.42% <0%> (-1.2%) 2% <0%> (ø)
...java/io/reactivex/processors/UnicastProcessor.java 94.73% <0%> (-1.17%) 63% <0%> (-1%)
...ivex/internal/operators/maybe/MaybeMergeArray.java 96.62% <0%> (-1.13%) 6% <0%> (ø)
.../operators/observable/ObservableSequenceEqual.java 98.31% <0%> (-0.85%) 2% <0%> (ø)
.../operators/maybe/MaybeFlatMapIterableFlowable.java 97.54% <0%> (-0.82%) 2% <0%> (ø)
.../operators/observable/ObservableCombineLatest.java 96.31% <0%> (-0.62%) 6% <0%> (ø)
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 182de28...5f0207a. Read the comment docs.

README.md Outdated
@@ -231,15 +231,19 @@ and for Ivy:
<dependency org="io.reactivex.rxjava2" name="rxjava" rev="x.y.z" />
```

Snapshots are available via [JFrog](https://oss.jfrog.org/webapp/#/home):
Snapshots are available via [JFrog](https://oss.jfrog.org/webapp/#/home) in [libs-snapshot/io/reactivex/rxjava2/rxjava/](https://oss.jfrog.org/libs-snapshot/io/reactivex/rxjava2/rxjava/)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just point to the second link directly instead of first one :)

README.md Outdated

```groovy
repositories {
maven { url 'https://oss.jfrog.org/libs-snapshot' }
}

dependencies {
// for versions 2.0.0 - 2.1.4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess having 2 snapshots in this case kinda defeats purpose of snapshots,

Snapshot just always point to latest build, so I'd just update 2.0.0-DP0-SNAPSHOT to 2.2.0-SNAPSHOT (and maybe change snapshot artifact name to 2.x-SNAPSHOT in a separate PR

@akarnokd akarnokd merged commit 831f6c8 into ReactiveX:2.x Oct 5, 2017
@akarnokd akarnokd deleted the SnapshotLinkUpdate branch October 5, 2017 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants