-
Notifications
You must be signed in to change notification settings - Fork 7.6k
2.x: Readme.md update snapshot links #5645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## 2.x #5645 +/- ##
============================================
+ Coverage 96.18% 96.25% +0.06%
- Complexity 5846 5849 +3
============================================
Files 634 634
Lines 41539 41539
Branches 5752 5752
============================================
+ Hits 39956 39985 +29
+ Misses 628 613 -15
+ Partials 955 941 -14
Continue to review full report at Codecov.
|
README.md
Outdated
@@ -231,15 +231,19 @@ and for Ivy: | |||
<dependency org="io.reactivex.rxjava2" name="rxjava" rev="x.y.z" /> | |||
``` | |||
|
|||
Snapshots are available via [JFrog](https://oss.jfrog.org/webapp/#/home): | |||
Snapshots are available via [JFrog](https://oss.jfrog.org/webapp/#/home) in [libs-snapshot/io/reactivex/rxjava2/rxjava/](https://oss.jfrog.org/libs-snapshot/io/reactivex/rxjava2/rxjava/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just point to the second link directly instead of first one :)
README.md
Outdated
|
||
```groovy | ||
repositories { | ||
maven { url 'https://oss.jfrog.org/libs-snapshot' } | ||
} | ||
|
||
dependencies { | ||
// for versions 2.0.0 - 2.1.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess having 2 snapshots in this case kinda defeats purpose of snapshots,
Snapshot just always point to latest build, so I'd just update 2.0.0-DP0-SNAPSHOT
to 2.2.0-SNAPSHOT
(and maybe change snapshot artifact name to 2.x-SNAPSHOT
in a separate PR
Update the snapshot link to the upcoming 2.1.5+ and 2.2.x versions. Also I've added a convenience link to the actual directory listing of the various snapshots hosted by JFrog.