Skip to content

2.x: coverage, add SingleToFlowableTest #5673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 16, 2017
Merged

Conversation

ggikko
Copy link
Contributor

@ggikko ggikko commented Oct 16, 2017

Add "SingleToFlowableTest" to cover toFlowable with test.

@codecov
Copy link

codecov bot commented Oct 16, 2017

Codecov Report

Merging #5673 into 2.x will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #5673      +/-   ##
============================================
- Coverage     96.28%   96.26%   -0.03%     
  Complexity     5817     5817              
============================================
  Files           633      633              
  Lines         41552    41552              
  Branches       5751     5751              
============================================
- Hits          40007    39998       -9     
- Misses          613      621       +8     
- Partials        932      933       +1
Impacted Files Coverage Δ Complexity Δ
...tivex/internal/schedulers/InstantPeriodicTask.java 61.11% <0%> (-5.56%) 7% <0%> (-2%)
...nternal/operators/parallel/ParallelReduceFull.java 91.17% <0%> (-3.93%) 2% <0%> (ø)
...l/operators/observable/ObservableFlatMapMaybe.java 88.23% <0%> (-3.93%) 2% <0%> (ø)
.../operators/observable/ObservableFlatMapSingle.java 88.8% <0%> (-3.74%) 2% <0%> (ø)
.../internal/operators/flowable/FlowableInterval.java 94.44% <0%> (-2.78%) 3% <0%> (ø)
...ternal/operators/observable/ObservablePublish.java 92.98% <0%> (-2.64%) 11% <0%> (+1%)
...ex/internal/subscribers/InnerQueuedSubscriber.java 96.07% <0%> (-1.97%) 18% <0%> (-1%)
...a/io/reactivex/internal/queue/MpscLinkedQueue.java 98.03% <0%> (-1.97%) 17% <0%> (-1%)
...a/io/reactivex/internal/util/QueueDrainHelper.java 60.28% <0%> (-1.42%) 32% <0%> (-1%)
...vex/internal/operators/flowable/FlowableCache.java 92.61% <0%> (-1.35%) 7% <0%> (ø)
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f2ceb4...1e510df. Read the comment docs.

@akarnokd
Copy link
Member

My mistake, looked at the complexity column.

@akarnokd akarnokd merged commit b0bc478 into ReactiveX:2.x Oct 16, 2017
@ggikko
Copy link
Contributor Author

ggikko commented Oct 16, 2017

well.. I thought it was not covered "if (DisposableHelper.validate(this.d, d))" in SingleToFlowable

I got it. thanks for link.

@ggikko
Copy link
Contributor Author

ggikko commented Oct 16, 2017

I have a question. There are many duplicate codes in Test code. How about zip these codes to one method for cleaning.

@akarnokd
Copy link
Member

You mean TestHelper? The types are different and they can't be reasonably factored out.

@ggikko
Copy link
Contributor Author

ggikko commented Oct 16, 2017

I see. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants