Skip to content

2.x: Fix flaky sample() backpressure test, improve coverage #6254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 19, 2018

Conversation

akarnokd
Copy link
Member

Use processors to trigger the MissingBackpressureException case instead of the timer, which could fire prematurely and stop the sequence before the first item was sent by the BehaviorProcessor.

Also small improvements to the code coverage of FlowableSample.

Fixes #6253.

@codecov
Copy link

codecov bot commented Oct 19, 2018

Codecov Report

Merging #6254 into 2.x will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##               2.x    #6254      +/-   ##
===========================================
+ Coverage     98.2%   98.28%   +0.07%     
- Complexity    6202     6206       +4     
===========================================
  Files          667      667              
  Lines        44889    44889              
  Branches      6216     6216              
===========================================
+ Hits         44082    44117      +35     
+ Misses         260      247      -13     
+ Partials       547      525      -22
Impacted Files Coverage Δ Complexity Δ
...ex/internal/subscriptions/SubscriptionArbiter.java 94.91% <0%> (-2.55%) 46% <0%> (-1%)
...ava/io/reactivex/processors/BehaviorProcessor.java 96.86% <0%> (-2.25%) 60% <0%> (ø)
...java/io/reactivex/processors/PublishProcessor.java 98.19% <0%> (-1.81%) 42% <0%> (-1%)
...tivex/internal/operators/single/SingleTimeout.java 98.33% <0%> (-1.67%) 2% <0%> (ø)
.../operators/observable/ObservableFlatMapSingle.java 88.8% <0%> (-1.5%) 2% <0%> (ø)
...nternal/operators/observable/ObservableCreate.java 97.43% <0%> (-0.86%) 2% <0%> (ø)
...l/operators/observable/ObservableTimeoutTimed.java 99.15% <0%> (-0.85%) 3% <0%> (ø)
...internal/operators/flowable/FlowableObserveOn.java 96.65% <0%> (-0.56%) 3% <0%> (ø)
...rnal/operators/flowable/FlowableFlatMapSingle.java 92.93% <0%> (-0.55%) 2% <0%> (ø)
...main/java/io/reactivex/subjects/ReplaySubject.java 97.69% <0%> (-0.42%) 50% <0%> (ø)
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f78bd95...6ff0cbe. Read the comment docs.

@akarnokd akarnokd merged commit 8654393 into ReactiveX:2.x Oct 19, 2018
@akarnokd akarnokd deleted the FlowableSampleTestFix branch October 19, 2018 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants