Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.x: Cleanup addThrowable, "2.x" and null-value error messages #6639

Merged
merged 1 commit into from Aug 28, 2019

Conversation

akarnokd
Copy link
Member

This PR renames the internal addThrowable to tryAddThrowable and introduces the tryAddThrowableOrReport to perform the common reporting to the global error handler. Usage places have been re-evaluated and fixed if necessary.

In addition, null exceptions have been made more uniform.

Resolves #6611

@akarnokd akarnokd added this to the 3.0 milestone Aug 28, 2019
@codecov
Copy link

codecov bot commented Aug 28, 2019

Codecov Report

Merging #6639 into 3.x will increase coverage by 0.01%.
The diff coverage is 98.73%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x    #6639      +/-   ##
============================================
+ Coverage     98.16%   98.17%   +0.01%     
- Complexity     6180     6193      +13     
============================================
  Files           678      678              
  Lines         44784    44690      -94     
  Branches       6177     6165      -12     
============================================
- Hits          43960    43876      -84     
+ Misses          282      279       -3     
+ Partials        542      535       -7
Impacted Files Coverage Δ Complexity Δ
...nal/operators/flowable/FlowableWindowBoundary.java 99.26% <100%> (-0.02%) 2 <0> (ø)
...3/internal/operators/flowable/FlowableGroupBy.java 95.51% <100%> (ø) 3 <0> (ø) ⬇️
...s/completable/CompletableMergeDelayErrorArray.java 97.61% <100%> (-0.06%) 6 <0> (ø)
...l/operators/observable/ObservableToListSingle.java 100% <100%> (ø) 4 <1> (ø) ⬇️
...internal/operators/observable/ObservableError.java 100% <100%> (ø) 2 <1> (ø) ⬇️
...nal/operators/flowable/FlowableBufferBoundary.java 95.95% <100%> (-0.07%) 2 <0> (ø)
...perators/mixed/ObservableSwitchMapCompletable.java 100% <100%> (ø) 3 <0> (ø) ⬇️
...ernal/operators/flowable/FlowableFlatMapMaybe.java 92.7% <100%> (-3.69%) 2 <0> (ø)
.../operators/observable/ObservableFlatMapSingle.java 96.03% <100%> (+4.62%) 2 <0> (ø) ⬇️
...rxjava3/internal/operators/single/SingleError.java 100% <100%> (ø) 2 <1> (ø) ⬇️
... and 104 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1441b0...0af0b67. Read the comment docs.

@akarnokd akarnokd merged commit a07c45e into ReactiveX:3.x Aug 28, 2019
@akarnokd akarnokd deleted the AddThrowableCleanup3x branch August 28, 2019 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3.x: Revise AtomicThrowable.addThrowable usage
2 participants