API Design Tweaks #670
Merged
API Design Tweaks #670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- keeping onNext to be locally consistent with doOnNext
- SingleAssignmentSubscription was removed in one merge, TakeLast modified in another merge.
- flattening map implementations that better fit mental models and use cases - keeping flatMap as alias to mergeMap since flatMap is common … (though flatMap still confuses people) - deprecate mapMany as alias to flatMap and mergeMap
If we leave mapWithIndex then we should have “withIndex” on many other operators. Instead of this, an Observable should just be zipped with an infinite stream of numbers and the zip function provides the index. This keeps the API surface area smaller and provides the desired behavior on all operators.
We have had aggregate from Rx.Net for a while but long ago migrated to reduce as the primary. Time to deprecate it.
|
RxJava-pull-requests #604 FAILURE |
| * @return the source Observable with the side-effecting behavior applied | ||
| * @see <a href="https://github.com/Netflix/RxJava/wiki/Observable-Utility-Operators#dooneach">RxJava Wiki: doOnEach()</a> | ||
| * @see <a href="http://msdn.microsoft.com/en-us/library/hh229539.aspx">MSDN: Observable.Do</a> | ||
| * @see <a href="https://github.com/Netflix/RxJava/wiki/Observable-Utility-Operators#dooneach">RxJava Wiki: doOnNext()</a> |
There was a problem hiding this comment.
The wiki link here points at the doOnEach entry, while doOnNext is undocumented there.
rickbw
pushed a commit
to rickbw/RxJava
that referenced
this pull request
Jan 9, 2014
API Design Tweaks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some changes resulting from review with @headinthebox and @jhusain
General principles pursued are to simplify the mental model and surface area of the API.