Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x: Add ProGuard rule to avoid j.u.c.Flow warnings due to RS 1.0.3 #6704

Merged
merged 1 commit into from Nov 7, 2019

Conversation

@akarnokd
Copy link
Member

akarnokd commented Nov 7, 2019

Add rule to ignore java.util.concurrent.Flow when using Android's R8 to prevent warnings about the FlowAdapter.class contained within the Reactive Streams JAR file.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 7, 2019

Codecov Report

Merging #6704 into 2.x will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6704      +/-   ##
============================================
- Coverage     98.24%   98.24%   -0.01%     
+ Complexity     6349     6347       -2     
============================================
  Files           677      677              
  Lines         45526    45526              
  Branches       6333     6333              
============================================
- Hits          44729    44725       -4     
- Misses          251      252       +1     
- Partials        546      549       +3
Impacted Files Coverage Δ Complexity Δ
...ernal/operators/flowable/FlowableFlatMapMaybe.java 88.88% <0%> (-6.77%) 2% <0%> (ø)
.../operators/flowable/FlowableBlockingSubscribe.java 93.02% <0%> (-4.66%) 10% <0%> (-1%)
...rnal/operators/flowable/FlowableFlatMapSingle.java 92.93% <0%> (-2.72%) 2% <0%> (ø)
.../operators/observable/ObservableFlatMapSingle.java 94.77% <0%> (-0.75%) 2% <0%> (ø)
...va/io/reactivex/processors/MulticastProcessor.java 98.23% <0%> (-0.45%) 83% <0%> (-1%)
...ex/internal/operators/flowable/FlowableCreate.java 96.77% <0%> (-0.33%) 6% <0%> (ø)
...ternal/operators/flowable/FlowableWindowTimed.java 92.09% <0%> (-0.24%) 4% <0%> (ø)
...l/operators/observable/ObservableFlatMapMaybe.java 87.58% <0%> (ø) 2% <0%> (ø) ⬇️
.../operators/observable/ObservableCombineLatest.java 96.93% <0%> (+0.61%) 6% <0%> (ø) ⬇️
...ex/internal/operators/flowable/FlowableReplay.java 94.75% <0%> (+0.83%) 20% <0%> (ø) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f01b08...c104269. Read the comment docs.

@akarnokd

This comment has been minimized.

Copy link
Member Author

akarnokd commented Nov 7, 2019

I'll merge this and pull in the snapshot in a Android project.

@akarnokd akarnokd merged commit ca0f2d7 into ReactiveX:2.x Nov 7, 2019
3 checks passed
3 checks passed
codecov/patch Coverage not affected when comparing 5f01b08...c104269
Details
codecov/project 98.24% (target 95%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@akarnokd akarnokd deleted the akarnokd:ProGuardInclude2x branch Nov 7, 2019
@akarnokd

This comment has been minimized.

Copy link
Member Author

akarnokd commented Nov 7, 2019

It didn't work.

image

@akarnokd

This comment has been minimized.

Copy link
Member Author

akarnokd commented Nov 7, 2019

This was AS 3.5. If I put the -dontwarn into the proguard-rules.pro of the project, it didn't work either.

Upgraded to AS 3.5.2. If I put -dontwarn into the proguard-rules.pro it works. Having only the rxjava2.pro still doesn't.

Edit. Running clean and make, the warnings are there. Running make again results in no warnings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.