Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x: ProGuard R8 dont warn Flow* classes #6705

Merged
merged 1 commit into from Nov 8, 2019

Conversation

@akarnokd
Copy link
Member

akarnokd commented Nov 7, 2019

#6704 didn't work, probably because the filter has to match a filename java.util.concurrent.Flow$Publisher, not some parent class name.

Having -dontwarn java.util.concurrent.Flow* did work in a test project's proguard file locally.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 7, 2019

Codecov Report

Merging #6705 into 2.x will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6705      +/-   ##
============================================
- Coverage     98.26%   98.23%   -0.03%     
- Complexity     6347     6349       +2     
============================================
  Files           677      677              
  Lines         45526    45526              
  Branches       6333     6333              
============================================
- Hits          44735    44724      -11     
- Misses          246      254       +8     
- Partials        545      548       +3
Impacted Files Coverage Δ Complexity Δ
...ernal/operators/flowable/FlowableFlatMapMaybe.java 90.82% <0%> (-3.87%) 2% <0%> (ø)
.../operators/observable/ObservableFlatMapSingle.java 91.79% <0%> (-2.99%) 2% <0%> (ø)
...tivex/internal/schedulers/TrampolineScheduler.java 96.1% <0%> (-2.6%) 6% <0%> (ø)
...va/io/reactivex/internal/queue/SpscArrayQueue.java 97.61% <0%> (-2.39%) 22% <0%> (-1%)
...nternal/operators/observable/ObservableCreate.java 96.58% <0%> (-1.71%) 2% <0%> (ø)
...rnal/operators/observable/ObservableSwitchMap.java 91.53% <0%> (-1.59%) 3% <0%> (ø)
...vex/internal/operators/parallel/ParallelRunOn.java 96.61% <0%> (-0.97%) 8% <0%> (ø)
.../operators/mixed/FlowableConcatMapCompletable.java 99.14% <0%> (-0.86%) 2% <0%> (ø)
...perators/mixed/ObservableConcatMapCompletable.java 99.24% <0%> (-0.76%) 3% <0%> (ø)
...ternal/operators/observable/ObservableFlatMap.java 88.67% <0%> (-0.65%) 3% <0%> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca0f2d7...e61c2da. Read the comment docs.

Copy link
Contributor

vanniktech left a comment

Ups. Yes. You need that *

@akarnokd akarnokd merged commit 3cb610f into ReactiveX:2.x Nov 8, 2019
3 checks passed
3 checks passed
codecov/patch Coverage not affected when comparing ca0f2d7...e61c2da
Details
codecov/project 98.23% (target 95%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@akarnokd akarnokd deleted the akarnokd:ProGuard2xAgain branch Nov 8, 2019
@akarnokd

This comment has been minimized.

Copy link
Member Author

akarnokd commented Nov 8, 2019

This works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.