Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.x: Fix Observable amb, combineLatest & zip ArrayStoreException #6756

Merged
merged 1 commit into from
Dec 11, 2019

Conversation

akarnokd
Copy link
Member

When using iterable of sources, the initial array is the wrong type and causes ArrayStoreException.

Unit tests were added to verify the other implementations.

Fixes #6753

@akarnokd akarnokd added this to the 3.0 milestone Dec 10, 2019
@codecov
Copy link

codecov bot commented Dec 10, 2019

Codecov Report

Merging #6756 into 3.x will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##                3.x   #6756      +/-   ##
===========================================
- Coverage     98.13%   98.1%   -0.04%     
+ Complexity     6190    6186       -4     
===========================================
  Files           677     677              
  Lines         44626   44626              
  Branches       6161    6161              
===========================================
- Hits          43794   43780      -14     
- Misses          300     303       +3     
- Partials        532     543      +11
Impacted Files Coverage Δ Complexity Δ
.../operators/observable/ObservableCombineLatest.java 96.81% <100%> (ø) 6 <0> (ø) ⬇️
...3/internal/operators/observable/ObservableZip.java 100% <100%> (ø) 6 <0> (ø) ⬇️
...3/internal/operators/observable/ObservableAmb.java 98.94% <100%> (ø) 8 <0> (ø) ⬇️
...l/operators/observable/ObservableFlatMapMaybe.java 83.8% <0%> (-11.27%) 2% <0%> (ø)
...rnal/subscribers/SinglePostCompleteSubscriber.java 92.3% <0%> (-7.7%) 14% <0%> (-1%)
...rxjava3/internal/observers/QueueDrainObserver.java 97.43% <0%> (-2.57%) 21% <0%> (-1%)
.../internal/disposables/ListCompositeDisposable.java 98% <0%> (-2%) 34% <0%> (-1%)
...tivex/rxjava3/disposables/CompositeDisposable.java 98.14% <0%> (-1.86%) 39% <0%> (-1%)
...perators/single/SingleFlatMapIterableFlowable.java 94.16% <0%> (-1.67%) 2% <0%> (ø)
...ernal/operators/flowable/FlowableFlatMapMaybe.java 92.7% <0%> (-1.05%) 2% <0%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec81e8c...db7ae4b. Read the comment docs.

@akarnokd akarnokd merged commit 01cae89 into ReactiveX:3.x Dec 11, 2019
@akarnokd akarnokd deleted the OpArrayCreationFix branch December 11, 2019 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants