Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.x: Fix Flowable.window (size, time) cancellation and abandonment #6758

Merged
merged 1 commit into from
Dec 16, 2019

Conversation

akarnokd
Copy link
Member

This PR fixes the Flowable.window operator (with size and time boundaries) so that

  • cancelling the inner windows allows cancelling the upstream once neither the main output nor other windows are being consumed further
  • ignoring a window still allows cancelling the upstream.

These fixes are necessary similar to how groupBy had to be updated in #6740.

The publisher-boundary and start-stop publisher boundary as well as the Observable variants will be updated in subsequent PRs due to the sheer number of changes.

@akarnokd akarnokd added this to the 3.0 milestone Dec 12, 2019
@codecov
Copy link

codecov bot commented Dec 12, 2019

Codecov Report

Merging #6758 into 3.x will increase coverage by 0.06%.
The diff coverage is 93.99%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x    #6758      +/-   ##
============================================
+ Coverage     98.08%   98.14%   +0.06%     
- Complexity     6190     6194       +4     
============================================
  Files           677      678       +1     
  Lines         44626    44580      -46     
  Branches       6161     6152       -9     
============================================
- Hits          43773    43755      -18     
+ Misses          310      295      -15     
+ Partials        543      530      -13
Impacted Files Coverage Δ Complexity Δ
.../main/java/io/reactivex/rxjava3/core/Flowable.java 100% <ø> (ø) 559 <0> (ø) ⬇️
...a3/internal/operators/flowable/FlowableWindow.java 89.8% <85.1%> (-1.73%) 4 <0> (ø)
...l/operators/flowable/WindowSubscribeIntercept.java 87.5% <87.5%> (ø) 4 <4> (?)
...ternal/operators/flowable/FlowableWindowTimed.java 96.63% <95.68%> (+3.84%) 5 <1> (+1) ⬆️
...l/operators/observable/ObservableFlatMapMaybe.java 83.8% <0%> (-4.93%) 2% <0%> (ø)
...rnal/operators/flowable/FlowableFlatMapSingle.java 92.44% <0%> (-2.91%) 2% <0%> (ø)
...perators/single/SingleFlatMapIterableFlowable.java 94.16% <0%> (-2.5%) 2% <0%> (ø)
...ava3/internal/operators/maybe/MaybeMergeArray.java 96.04% <0%> (-1.13%) 6% <0%> (ø)
.../operators/observable/ObservableCombineLatest.java 96.17% <0%> (-0.64%) 6% <0%> (ø)
...activex/rxjava3/processors/MulticastProcessor.java 98.23% <0%> (-0.45%) 83% <0%> (-1%)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01cae89...ea416b2. Read the comment docs.

@akarnokd akarnokd merged commit df7f1cd into ReactiveX:3.x Dec 16, 2019
@akarnokd akarnokd deleted the WindowCancellationFix3x branch December 16, 2019 10:00
Copy link
Collaborator

@vanniktech vanniktech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants