Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Replace some ObjecsHelpers methods with Java 8 APIs #6770

Merged
merged 1 commit into from Dec 17, 2019
Merged

[3.x] Replace some ObjecsHelpers methods with Java 8 APIs #6770

merged 1 commit into from Dec 17, 2019

Conversation

JakeWharton
Copy link
Member

No description provided.

@JakeWharton JakeWharton changed the title [3.x] Replace some ObjecsHelpers methods with Java 8 Objects [3.x] Replace some ObjecsHelpers methods with Java 8 APIs Dec 17, 2019
@akarnokd akarnokd added 3.x Cleanup Java 8 Issues and PRs related to Java 8 support labels Dec 17, 2019
@akarnokd akarnokd added this to the 3.0 milestone Dec 17, 2019
@JakeWharton
Copy link
Member Author

These are all desugared as of AGP 3.5.

@codecov
Copy link

codecov bot commented Dec 17, 2019

Codecov Report

Merging #6770 into 3.x will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x    #6770      +/-   ##
============================================
- Coverage     98.23%   98.22%   -0.02%     
+ Complexity     6205     6192      -13     
============================================
  Files           681      681              
  Lines         44783    44779       -4     
  Branches       6164     6164              
============================================
- Hits          43994    43985       -9     
- Misses          275      278       +3     
- Partials        514      516       +2
Impacted Files Coverage Δ Complexity Δ
...xjava3/internal/operators/single/SingleEquals.java 93.93% <100%> (ø) 2 <0> (ø) ⬇️
...xjava3/internal/operators/maybe/MaybeContains.java 100% <100%> (ø) 3 <0> (ø) ⬇️
...java3/internal/schedulers/TrampolineScheduler.java 98.7% <100%> (ø) 6 <0> (ø) ⬇️
...eactivex/rxjava3/internal/functions/Functions.java 99.15% <100%> (ø) 37 <0> (ø) ⬇️
...tivex/rxjava3/internal/functions/ObjectHelper.java 100% <100%> (ø) 9 <0> (-12) ⬇️
...io/reactivex/rxjava3/schedulers/TestScheduler.java 100% <100%> (ø) 11 <0> (ø) ⬇️
...in/java/io/reactivex/rxjava3/schedulers/Timed.java 100% <100%> (ø) 13 <0> (ø) ⬇️
.../reactivex/rxjava3/observers/BaseTestConsumer.java 97.23% <100%> (ø) 69 <0> (ø) ⬇️
...ctivex/rxjava3/internal/util/NotificationLite.java 100% <100%> (ø) 30 <0> (ø) ⬇️
...n/java/io/reactivex/rxjava3/core/Notification.java 93.93% <100%> (ø) 22 <0> (ø) ⬇️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2392349...31e245a. Read the comment docs.

@akarnokd akarnokd merged commit 652f2a1 into ReactiveX:3.x Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x Cleanup Java 8 Issues and PRs related to Java 8 support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants