Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.x: Improve Javadocs of Single #6812

Merged
merged 1 commit into from Jan 6, 2020
Merged

Conversation

@akarnokd
Copy link
Member

akarnokd commented Jan 6, 2020

  • Use {@link}s and {@code} tags
  • Fix some wording and copy-paste mistakes
  • Add @throws about argument validation throwing NullPointerExceptions and IllegalArgumentExceptions
@akarnokd akarnokd added this to the 3.0 milestone Jan 6, 2020
@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 6, 2020

Codecov Report

Merging #6812 into 3.x will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x    #6812      +/-   ##
============================================
+ Coverage     98.24%   98.27%   +0.03%     
- Complexity     6385     6387       +2     
============================================
  Files           715      715              
  Lines         46498    46498              
  Branches       6371     6371              
============================================
+ Hits          45680    45694      +14     
+ Misses          295      287       -8     
+ Partials        523      517       -6
Impacted Files Coverage Δ Complexity Δ
...rc/main/java/io/reactivex/rxjava3/core/Single.java 100% <ø> (ø) 153 <0> (ø) ⬇️
.../operators/observable/ObservableFlatMapSingle.java 88.09% <0%> (-3.97%) 2% <0%> (ø)
.../internal/disposables/ListCompositeDisposable.java 98% <0%> (-2%) 34% <0%> (-1%)
...rnal/operators/flowable/FlowableFlatMapSingle.java 94.18% <0%> (-1.17%) 2% <0%> (ø)
...eactivex/rxjava3/processors/BehaviorProcessor.java 98.02% <0%> (-0.99%) 49% <0%> (-1%)
...a3/internal/operators/flowable/FlowableReplay.java 91.99% <0%> (-0.83%) 19% <0%> (ø)
...ernal/operators/flowable/FlowableFromIterable.java 96.25% <0%> (-0.54%) 5% <0%> (ø)
.../reactivex/rxjava3/processors/ReplayProcessor.java 97.34% <0%> (-0.41%) 52% <0%> (ø)
...3/internal/operators/flowable/FlowableGroupBy.java 95.59% <0%> (ø) 3% <0%> (ø) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e54ea2d...b402bcb. Read the comment docs.

@akarnokd akarnokd merged commit 4c8d49b into ReactiveX:3.x Jan 6, 2020
3 checks passed
3 checks passed
codecov/patch Coverage not affected when comparing e54ea2d...b402bcb
Details
codecov/project 98.27% (target 95%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@akarnokd akarnokd deleted the akarnokd:JavadocCleanup0106a branch Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.