Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.x: Add Maybe.dematerialize #6871

Merged
merged 1 commit into from
Jan 25, 2020
Merged

Conversation

akarnokd
Copy link
Member

Add the dematerialize operator to Maybe to be in sync with the other classes.

Related #6852

image

@akarnokd akarnokd added this to the 3.0 milestone Jan 25, 2020
@codecov
Copy link

codecov bot commented Jan 25, 2020

Codecov Report

Merging #6871 into 3.x will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x    #6871      +/-   ##
============================================
+ Coverage     98.27%   98.29%   +0.01%     
- Complexity     6446     6447       +1     
============================================
  Files           722      723       +1     
  Lines         46783    46817      +34     
  Branches       6401     6404       +3     
============================================
+ Hits          45977    46019      +42     
+ Misses          289      282       -7     
+ Partials        517      516       -1
Impacted Files Coverage Δ Complexity Δ
...rc/main/java/io/reactivex/rxjava3/core/Single.java 100% <ø> (ø) 160 <0> (ø) ⬇️
...3/internal/operators/maybe/MaybeDematerialize.java 100% <100%> (ø) 2 <2> (?)
src/main/java/io/reactivex/rxjava3/core/Maybe.java 100% <100%> (ø) 188 <1> (+1) ⬆️
...l/operators/observable/ObservableFlatMapMaybe.java 91.54% <0%> (-5.64%) 2% <0%> (ø)
.../operators/flowable/FlowableBlockingSubscribe.java 93.02% <0%> (-4.66%) 10% <0%> (-1%)
...ctivex/rxjava3/internal/util/QueueDrainHelper.java 97.22% <0%> (-2.78%) 56% <0%> (-2%)
.../internal/disposables/ListCompositeDisposable.java 98% <0%> (-2%) 34% <0%> (-1%)
...ternal/operators/completable/CompletableMerge.java 95.94% <0%> (-1.36%) 2% <0%> (ø)
...a3/internal/operators/flowable/FlowableCreate.java 96.11% <0%> (-1.3%) 6% <0%> (ø)
...ava3/internal/operators/maybe/MaybeMergeArray.java 96.04% <0%> (-1.13%) 6% <0%> (ø)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53ba435...f41fb2e. Read the comment docs.

@akarnokd akarnokd merged commit ea8ab3b into ReactiveX:3.x Jan 25, 2020
@akarnokd akarnokd deleted the MaybeDematerialize branch January 25, 2020 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant