Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.x: Add Single.ofType #6876

Merged
merged 1 commit into from
Jan 26, 2020
Merged

3.x: Add Single.ofType #6876

merged 1 commit into from
Jan 26, 2020

Conversation

akarnokd
Copy link
Member

Add ofType to Single already available to the other non-empty base types.

Related #6852

image

In addition, diagrams for Maybe.filter and Maybe.ofType have been updated:

image
image

Related: #5806

@codecov
Copy link

codecov bot commented Jan 26, 2020

Codecov Report

Merging #6876 into 3.x will increase coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##                3.x   #6876      +/-   ##
===========================================
+ Coverage     98.22%   98.3%   +0.07%     
- Complexity     6525    6527       +2     
===========================================
  Files           733     733              
  Lines         47052   47054       +2     
  Branches       6425    6425              
===========================================
+ Hits          46216   46255      +39     
+ Misses          305     289      -16     
+ Partials        531     510      -21
Impacted Files Coverage Δ Complexity Δ
src/main/java/io/reactivex/rxjava3/core/Maybe.java 100% <ø> (ø) 199 <0> (ø) ⬇️
...rc/main/java/io/reactivex/rxjava3/core/Single.java 100% <100%> (ø) 171 <1> (+1) ⬆️
.../internal/disposables/ListCompositeDisposable.java 98% <0%> (-2%) 34% <0%> (-1%)
...ternal/operators/completable/CompletableMerge.java 95.94% <0%> (-1.36%) 2% <0%> (ø)
...ava3/internal/operators/parallel/ParallelJoin.java 92.04% <0%> (-1.14%) 3% <0%> (ø)
...operators/observable/ObservableMergeWithMaybe.java 99.09% <0%> (-0.91%) 2% <0%> (ø)
.../operators/maybe/MaybeFlatMapIterableFlowable.java 95.9% <0%> (-0.82%) 2% <0%> (ø)
...a3/internal/operators/flowable/FlowableCreate.java 96.76% <0%> (-0.65%) 6% <0%> (ø)
...ernal/operators/flowable/FlowableFromIterable.java 96.25% <0%> (-0.54%) 5% <0%> (ø)
...3/internal/operators/flowable/FlowableGroupBy.java 96.22% <0%> (+0.31%) 3% <0%> (ø) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c85f5a...51380db. Read the comment docs.

@akarnokd akarnokd merged commit db0bd71 into ReactiveX:3.x Jan 26, 2020
@akarnokd akarnokd deleted the OfType3x branch January 26, 2020 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant