Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.x: Fix toFlowable(ERROR) not cancelling on MBE #7083

Merged
merged 1 commit into from
Sep 23, 2020

Conversation

akarnokd
Copy link
Member

There was a missing upstream.cancel() for when the overflow happens.

Fixes #7081

@akarnokd akarnokd added this to the 3.1 milestone Sep 23, 2020
@codecov
Copy link

codecov bot commented Sep 23, 2020

Codecov Report

Merging #7083 into 3.x will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x    #7083      +/-   ##
============================================
+ Coverage     99.51%   99.54%   +0.02%     
  Complexity     6670     6670              
============================================
  Files           742      742              
  Lines         47275    47276       +1     
  Branches       6374     6374              
============================================
+ Hits          47045    47060      +15     
+ Misses          105      100       -5     
+ Partials        125      116       -9     
Impacted Files Coverage Δ Complexity Δ
...perators/flowable/FlowableOnBackpressureError.java 100.00% <100.00%> (ø) 2.00 <0.00> (ø)
...xjava3/internal/observers/FutureMultiObserver.java 96.61% <0.00%> (-3.39%) 27.00% <0.00%> (-1.00%)
...ctivex/rxjava3/internal/util/QueueDrainHelper.java 98.61% <0.00%> (-1.39%) 57.00% <0.00%> (-1.00%)
...rnal/operators/observable/ObservableObserveOn.java 98.69% <0.00%> (-1.31%) 3.00% <0.00%> (ø%)
...a3/internal/operators/flowable/FlowableCreate.java 97.73% <0.00%> (-1.30%) 6.00% <0.00%> (ø%)
...ernal/operators/flowable/FlowableFlatMapMaybe.java 96.89% <0.00%> (-1.04%) 2.00% <0.00%> (ø%)
...java3/internal/operators/flowable/FlowableZip.java 98.97% <0.00%> (-1.03%) 6.00% <0.00%> (ø%)
...operators/observable/ObservableMergeWithMaybe.java 99.09% <0.00%> (-0.91%) 2.00% <0.00%> (ø%)
...al/operators/observable/ObservableWindowTimed.java 97.09% <0.00%> (+0.32%) 4.00% <0.00%> (ø%)
...operators/flowable/FlowableConcatMapScheduler.java 99.60% <0.00%> (+0.39%) 4.00% <0.00%> (ø%)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe71f6a...4428e84. Read the comment docs.

Copy link
Collaborator

@vanniktech vanniktech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also here, does Observable behave correctly?

@akarnokd akarnokd merged commit 0690c7c into ReactiveX:3.x Sep 23, 2020
@akarnokd akarnokd deleted the ToFlowableErrorFix3x branch September 23, 2020 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2.x - Observable.toFlowable(ERROR) not releasing upstream on MissingBackPressure
2 participants