Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.x: Update marbles of amb(), ambArray() and ambWith() #7144

Merged
merged 2 commits into from
Jan 8, 2021

Conversation

akarnokd
Copy link
Member

@akarnokd akarnokd commented Jan 8, 2021

Update the marble diagrams in Flowable and Observable, indicating cancellation of the non-winners.

Resolves #6995

image
image
image
image
image
image

@akarnokd akarnokd added this to the 3.1 milestone Jan 8, 2021
@codecov
Copy link

codecov bot commented Jan 8, 2021

Codecov Report

Merging #7144 (f1e8984) into 3.x (b75c185) will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x    #7144      +/-   ##
============================================
- Coverage     99.57%   99.50%   -0.07%     
+ Complexity     6706     6705       -1     
============================================
  Files           745      745              
  Lines         47327    47327              
  Branches       6375     6375              
============================================
- Hits          47124    47091      -33     
- Misses           89      109      +20     
- Partials        114      127      +13     
Impacted Files Coverage Δ Complexity Δ
.../main/java/io/reactivex/rxjava3/core/Flowable.java 100.00% <ø> (ø) 597.00 <0.00> (ø)
...ain/java/io/reactivex/rxjava3/core/Observable.java 100.00% <ø> (ø) 565.00 <0.00> (ø)
...ors/flowable/FlowableOnBackpressureReduceWith.java 88.00% <0.00%> (-12.00%) 2.00% <0.00%> (ø%)
...tivex/rxjava3/internal/jdk8/ParallelCollector.java 89.90% <0.00%> (-8.26%) 2.00% <0.00%> (ø%)
...l/operators/observable/ObservableFlatMapMaybe.java 92.25% <0.00%> (-4.23%) 2.00% <0.00%> (ø%)
...rnal/operators/flowable/FlowableFlatMapSingle.java 94.18% <0.00%> (-3.49%) 2.00% <0.00%> (ø%)
...xjava3/internal/observers/FutureMultiObserver.java 96.61% <0.00%> (-3.39%) 27.00% <0.00%> (-1.00%)
...a/io/reactivex/rxjava3/subjects/SingleSubject.java 97.53% <0.00%> (-2.47%) 37.00% <0.00%> (-1.00%)
...nternal/operators/parallel/ParallelSortedJoin.java 98.49% <0.00%> (-1.51%) 2.00% <0.00%> (ø%)
...ternal/operators/completable/CompletableMerge.java 97.29% <0.00%> (-1.36%) 2.00% <0.00%> (ø%)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b75c185...f1e8984. Read the comment docs.

@akarnokd akarnokd merged commit a55f43e into ReactiveX:3.x Jan 8, 2021
@akarnokd akarnokd deleted the AmbMarbles3x branch January 8, 2021 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3.x: Observable.amb marble diagram is a bit incorrect (or maybe it's a bug?)
2 participants