embedded table: various improvements #43
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I will prepare the Unit-test if you are fine with the patch. |
Member
|
I need to sleep with it :) |
goneri
force-pushed
the
embedded
branch
3 times, most recently
from
37f2ce7 to
9efaa83
Compare
goneri
changed the title
With this commit, it's now possible to embbed different row of the same table. We use the DOMAIN to know the name resource to embed. This instead of the name of the field.
use the embeddable key to know if a resource should be embedded in the result.
Expend the $table.$field entry from the structure passed throught the embedded parameter.
Only retrieve the two first level of depth of embeddable resources.
Contributor
Author
|
I need more time to finish this patch. i will reopen a PR later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit, it's now possible to embbed different row of the same table.
We use the DOMAIN to know the name resource to embed. This instead of the
name of the field.