Merge branch 'master' into ck-docfix3.9

Author: alonre24

.circleci/config.yml

@@ -139,11 +139,6 @@ commands:
       - run:
           name: Build
           command: make -C opt all SHOW=1
-      - run:
-          name: Unit Tests
-          command: |
-            make -C opt unit_tests SHOW=1
-          no_output_timeout: 5m
       - run:
           name: Test
           command: |

.gitmodules

@@ -1,6 +1,3 @@
 [submodule "opt/readies"]
 	path = opt/readies
 	url = https://github.com/RedisLabsModules/readies.git
-[submodule "opt/googletest"]
-	path = opt/googletest
-	url = https://github.com/google/googletest.git

CMakeLists.txt

@@ -3,7 +3,6 @@ PROJECT(RedisAI)
 
 # CMake modules should be included in ${PROJECT_SOURCE_DIR}/opt/cmake/modules
 list(APPEND CMAKE_MODULE_PATH ${PROJECT_SOURCE_DIR}/opt/cmake/modules)
-list(APPEND CMAKE_MODULE_PATH ${PROJECT_SOURCE_DIR}/opt/GoogleTest)
 
 # Set a default build type if none was specified
 set(default_build_type "Release")
@@ -50,7 +49,6 @@ set(CMAKE_CXX_FLAGS_DEBUG "${CMAKE_CXX_FLAGS_DEBUG} ${CMAKE_COMMON_FLAGS_DEBUG}"
 
 #----------------------------------------------------------------------------------------------
 
-option(PACKAGE_UNIT_TESTS "Build unit tests" ON)
 option(BUILD_TF "Build the TensorFlow backend" ON)
 option(BUILD_TFLITE "Build the TensorFlow Lite backend" ON)
 option(BUILD_ORT "Build the ONNXRuntime backend" ON)
@@ -321,10 +319,3 @@ ENDIF()
 IF (NOT ${installAbs} STREQUAL ${CMAKE_SOURCE_DIR}/install-${DEVICE})
     INSTALL_SYMLINK(${installAbs} ${CMAKE_SOURCE_DIR}/install-${DEVICE})
 ENDIF()
-
-
-if(PACKAGE_UNIT_TESTS)
-    enable_testing()
-    include(GoogleTest)
-    add_subdirectory(tests/unit)
-endif()

docs/commands.md

@@ -335,8 +335,9 @@ redis> AI.MODELGET mymodel META
 You can also save it to the local file 'model.ext' with [`redis-cli`](https://redis.io/topics/cli) like so:
 
 ```
-$ redis-cli --raw AI.MODELGET mymodel BLOB > model.ext
+$ redis-cli AI.MODELGET mymodel BLOB > model.ext
 ```
+Note that for the time being, redis-cli adds additional linefeed character to redirected output so that the model blob retrieved with redis-cli will have an additional linefeed character.
 
 ## AI.MODELDEL
 The **`AI.MODELDEL`** deletes a model stored as a key's value.

opt/Makefile

@@ -41,10 +41,7 @@ make clean      # remove build artifacts
   ALL=1           # remove entire artifacts directory
 make install    # create ready-to-run scheme (module and engines)
 
-make test        # run test suites (flow an unit)
-				 # same as running make unit_tests flow_tests
-
-make unit_tests  # run unit test
+make test        # run test suites (flow)
 
 make flow_tests  # run flow test
   TEST=test        # run only test `test` with Redis output
@@ -242,13 +239,6 @@ export GEN ?= 1
 export SLAVES ?= 1
 export CLUSTER ?= 1
 
-define UNIT_TESTS
-$(SHOW)echo Running unit tests ...
-$(SHOW)\
-BINDIR=$(realpath $(BINDIR)) \
-$(ROOT)/tests/unit/tests.sh
-endef
-
 define FLOW_TESTS
 $(SHOW)echo Running flow tests ...
 $(SHOW)\
@@ -260,11 +250,6 @@ VALGRIND=$(VALGRIND) \
 $(ROOT)/tests/flow/tests_setup/tests.sh
 endef
 
-unit_tests: build
-	$(COVERAGE_RESET)
-	$(UNIT_TESTS)
-	$(COVERAGE_COLLECT_REPORT)
-
 flow_tests: build
 	$(COVERAGE_RESET)
 	$(SHOW)\
@@ -280,10 +265,6 @@ flow_tests: build
 
 test: build
 	$(COVERAGE_RESET)
-	$(UNIT_TESTS)
-	$(SHOW)\
-		BINDIR=$(realpath $(BINDIR)) \
-		$(ROOT)/tests/unit/tests.sh
 	$(SHOW)\
 		DEVICE=$(DEVICE) \
 		MODULE=$(realpath $(INSTALLED_TARGET)) \