Skip to content

Conversation

rafie
Copy link
Contributor

@rafie rafie commented Feb 25, 2020

No description provided.

@lgtm-com
Copy link

lgtm-com bot commented Feb 25, 2020

This pull request introduces 3 alerts when merging 0407ddf into a79c10e - view on LGTM.com

new alerts:

  • 2 for Unused import
  • 1 for Syntax error

@lgtm-com
Copy link

lgtm-com bot commented Feb 25, 2020

This pull request introduces 3 alerts when merging ca001a5 into a79c10e - view on LGTM.com

new alerts:

  • 2 for Unused import
  • 1 for Syntax error

@lgtm-com
Copy link

lgtm-com bot commented Feb 25, 2020

This pull request introduces 3 alerts when merging cce38b0 into a79c10e - view on LGTM.com

new alerts:

  • 2 for Unused import
  • 1 for Syntax error

@lgtm-com
Copy link

lgtm-com bot commented Feb 25, 2020

This pull request introduces 3 alerts when merging 9366044 into a79c10e - view on LGTM.com

new alerts:

  • 2 for Unused import
  • 1 for Syntax error

@lgtm-com
Copy link

lgtm-com bot commented Feb 25, 2020

This pull request introduces 3 alerts when merging 13bbba7 into a79c10e - view on LGTM.com

new alerts:

  • 2 for Unused import
  • 1 for Syntax error

@lgtm-com
Copy link

lgtm-com bot commented Feb 27, 2020

This pull request introduces 3 alerts when merging 30dfcf7 into a79c10e - view on LGTM.com

new alerts:

  • 2 for Unused import
  • 1 for Syntax error

@lgtm-com
Copy link

lgtm-com bot commented Feb 27, 2020

This pull request introduces 3 alerts when merging 62d76a6 into a79c10e - view on LGTM.com

new alerts:

  • 2 for Unused import
  • 1 for Syntax error

@lgtm-com
Copy link

lgtm-com bot commented Feb 27, 2020

This pull request introduces 3 alerts when merging 7c3ff5c into a79c10e - view on LGTM.com

new alerts:

  • 2 for Unused import
  • 1 for Syntax error

@lgtm-com
Copy link

lgtm-com bot commented Feb 27, 2020

This pull request introduces 3 alerts when merging c4775f1 into a79c10e - view on LGTM.com

new alerts:

  • 2 for Unused import
  • 1 for Syntax error

@lgtm-com
Copy link

lgtm-com bot commented Feb 27, 2020

This pull request introduces 3 alerts when merging 40d4302 into a79c10e - view on LGTM.com

new alerts:

  • 2 for Unused import
  • 1 for Syntax error

@lgtm-com
Copy link

lgtm-com bot commented Feb 27, 2020

This pull request introduces 3 alerts when merging bb3955a into a79c10e - view on LGTM.com

new alerts:

  • 2 for Unused import
  • 1 for Syntax error

@lgtm-com
Copy link

lgtm-com bot commented Feb 28, 2020

This pull request introduces 3 alerts when merging 558aea3 into a79c10e - view on LGTM.com

new alerts:

  • 2 for Unused import
  • 1 for Syntax error

@codecov
Copy link

codecov bot commented Feb 28, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@a79c10e). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #299   +/-   ##
=========================================
  Coverage          ?   53.24%           
=========================================
  Files             ?       25           
  Lines             ?     4631           
  Branches          ?        0           
=========================================
  Hits              ?     2466           
  Misses            ?     2165           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a79c10e...857a986. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented Feb 28, 2020

This pull request introduces 3 alerts when merging c80d458 into a79c10e - view on LGTM.com

new alerts:

  • 2 for Unused import
  • 1 for Syntax error

@lgtm-com
Copy link

lgtm-com bot commented Feb 28, 2020

This pull request introduces 3 alerts when merging 91b0320 into a79c10e - view on LGTM.com

new alerts:

  • 2 for Unused import
  • 1 for Syntax error

@rafie rafie marked this pull request as ready for review March 1, 2020 08:12
@rafie rafie changed the title [WIP] Readies sync (mk/coverage) Readies sync (mk/coverage) Mar 1, 2020
@rafie rafie requested review from lantiga and filipecosta90 March 1, 2020 08:20
@lgtm-com
Copy link

lgtm-com bot commented Mar 1, 2020

This pull request introduces 3 alerts when merging 412d8af into 95b7722 - view on LGTM.com

new alerts:

  • 2 for Unused import
  • 1 for Syntax error

@lgtm-com
Copy link

lgtm-com bot commented Mar 1, 2020

This pull request introduces 3 alerts when merging 857a986 into 95b7722 - view on LGTM.com

new alerts:

  • 2 for Unused import
  • 1 for Syntax error

Copy link
Contributor

@lantiga lantiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lantiga lantiga merged commit 39cfa6d into master Mar 1, 2020
@rafie rafie deleted the rafi-readies2 branch March 5, 2020 15:21
lantiga pushed a commit that referenced this pull request May 6, 2020
 
Readies sync (mk/coverage) (#299)

* readies sync (mk/cmake)

* fixes 1

* fixes 2

* fixes 3

* Tests/Valgrind refactoring

* fixes 4

* fixes 5

* fixes 6

* fixes 7

* fixes 8

* fixes 9

* fixes 10

* fixes 11

* fixes 12

* fixes 13

* fixes 14

* fixes 15

* fixes 16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants