Skip to content

Add MODELSTORE and MODELEXECUTE #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
May 19, 2021

Conversation

alonre24
Copy link
Collaborator

Add the support in the new commands: AI.MODELEXECUTE (AI.MODELRUN is now deprecated) and AI.MODELSTORE (AI.MODELSET is now deprecated).

@alonre24 alonre24 requested review from DvirDukhan and hhsecond April 26, 2021 14:26
@alonre24 alonre24 self-assigned this Apr 26, 2021
@codecov
Copy link

codecov bot commented May 12, 2021

Codecov Report

Merging #60 (40e50a8) into master (6486d6e) will decrease coverage by 0.46%.
The diff coverage is 95.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #60      +/-   ##
==========================================
- Coverage   97.36%   96.90%   -0.47%     
==========================================
  Files           8        8              
  Lines         684      776      +92     
==========================================
+ Hits          666      752      +86     
- Misses         18       24       +6     
Impacted Files Coverage Δ
redisai/postprocessor.py 100.00% <ø> (ø)
redisai/command_builder.py 89.68% <86.36%> (-2.18%) ⬇️
redisai/client.py 96.96% <100.00%> (+0.37%) ⬆️
redisai/dag.py 98.07% <100.00%> (ø)
redisai/pipeline.py 84.84% <100.00%> (ø)
redisai/utils.py 97.50% <100.00%> (ø)
test/test.py 99.74% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6486d6e...40e50a8. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented May 12, 2021

This pull request introduces 2 alerts and fixes 2 when merging f98dfdb into 6486d6e - view on LGTM.com

new alerts:

  • 2 for Unused import

fixed alerts:

  • 2 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented May 12, 2021

This pull request introduces 2 alerts and fixes 2 when merging 5448fc3 into 6486d6e - view on LGTM.com

new alerts:

  • 2 for Unused import

fixed alerts:

  • 2 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented May 19, 2021

This pull request introduces 2 alerts and fixes 2 when merging 034ced1 into 6486d6e - view on LGTM.com

new alerts:

  • 2 for Unused import

fixed alerts:

  • 2 for Unused import

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
1.9% 1.9% Duplication

@lgtm-com
Copy link

lgtm-com bot commented May 19, 2021

This pull request introduces 2 alerts and fixes 2 when merging 40e50a8 into 6486d6e - view on LGTM.com

new alerts:

  • 2 for Unused import

fixed alerts:

  • 2 for Unused import

@alonre24 alonre24 merged commit 3a7d3a6 into master May 19, 2021
@alonre24 alonre24 deleted the Add_modelstore_and_modelexecute_commands branch May 19, 2021 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants