SCRIPTEXECUTE support #68
Conversation
circleci docker build and publish build instructions
Codecov Report
@@ Coverage Diff @@
## master #68 +/- ##
==========================================
+ Coverage 96.90% 97.40% +0.49%
==========================================
Files 8 8
Lines 776 848 +72
==========================================
+ Hits 752 826 +74
+ Misses 24 22 -2
Continue to review full report at Codecov.
|
removing second poetry build call, since they can be done in one
There was a problem hiding this comment.
Nice work! (specially for a first task in RedisAI...), please follow the comments. Note that you should indicate that scriptrun is deprecated by using the suitable decorator (as we do in modelrun).
Regarding the tests, I think that there are many redundant checks that are not specific to the redisai-py client, and that we don't need to copy those from the flow tests. On the other hand, we may want to add some tests of running scripts that are using Redis commands (we can discuss it further on slack...)
…disai-py into scriptexecute_support
|
This pull request fixes 2 alerts when merging d17b278 into 3a7d3a6 - view on LGTM.com fixed alerts:
|
|
This pull request fixes 2 alerts when merging a2e4b65 into 3a7d3a6 - view on LGTM.com fixed alerts:
|
|
This pull request fixes 2 alerts when merging 24537c8 into 3a7d3a6 - view on LGTM.com fixed alerts:
|
Change the function variable in scriptrun function from AnyStr to str
|
Kudos, SonarCloud Quality Gate passed!
|
|
This pull request fixes 2 alerts when merging 53b1106 into 3a7d3a6 - view on LGTM.com fixed alerts:
|
AvitalFineRedis
force-pushed
the
scriptexecute_support
branch
from
8d9807b
to
918766e
Compare
…ptexecute_support # Conflicts: # test/test.py
redisai/dag.py
Outdated
| from redisai.postprocessor import Processor | ||
| from redisai import command_builder as builder | ||
|
|
There was a problem hiding this comment.
I don't think it's mine :0
I saw here some of Chayim's commits
There was a problem hiding this comment.
I see here some functions that use builder. The DagTestCase does not pass without this import
redisai/pipeline.py
Outdated
|
|
||
| from redisai import command_builder as builder | ||
| import redis |
There was a problem hiding this comment.
Why there is a diff here?
There was a problem hiding this comment.
PipelineTest does not pass without it
|
Kudos, SonarCloud Quality Gate passed!
|
No description provided.