Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: miniconda #173

Merged
merged 11 commits into from
May 14, 2018
Merged

ENH: miniconda #173

merged 11 commits into from
May 14, 2018

Conversation

kaczmarj
Copy link
Collaborator

Fixes #147

Breaking changes:

  • replaces env_name and preinstalled with create_env and use_env.
    • create_env creates a new environment with conda create.
    • use_env assumes the environment already exists and installs things into it.

Adds ability to create conda environment from yaml file.
Fixes environment variable logic. Environment variables are included when necessary and at most once.

@codecov-io
Copy link

codecov-io commented May 14, 2018

Codecov Report

Merging #173 into master will decrease coverage by 0.45%.
The diff coverage is 51.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #173      +/-   ##
==========================================
- Coverage   82.31%   81.86%   -0.46%     
==========================================
  Files          33       33              
  Lines        1453     1472      +19     
  Branches      140      146       +6     
==========================================
+ Hits         1196     1205       +9     
- Misses        192      198       +6     
- Partials       65       69       +4
Impacted Files Coverage Δ
neurodocker/tests/test_neurodocker.py 94.11% <ø> (ø) ⬆️
neurodocker/interfaces/tests/test_miniconda.py 100% <ø> (ø) ⬆️
neurodocker/generators/singularity.py 77.96% <100%> (+0.37%) ⬆️
neurodocker/interfaces/interfaces.py 80% <46.15%> (-5.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8607690...eb86ff9. Read the comment docs.

@kaczmarj kaczmarj merged commit a6596a4 into master May 14, 2018
@kaczmarj kaczmarj deleted the enh/miniconda branch May 14, 2018 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants