-
Notifications
You must be signed in to change notification settings - Fork 89
docs: fix broken links #1603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix broken links #1603
Conversation
WalkthroughThis pull request uniformly updates several API endpoint URLs across the toolbox package. The changes replace instances of Changes
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/toolbox/README.md (1)
76-77
: Markdown link contains an empty URL.The link
[https://api.request.finance/currency/list/name]()
is missing a target URL. To ensure the documentation properly directs users, please update it to include the URL (for example:[https://api.request.finance/currency/list/name](https://api.request.finance/currency/list/name)
).🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
76-76: No empty links
null(MD042, no-empty-links)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
packages/toolbox/README.md
(1 hunks)packages/toolbox/src/commands/chainlink/addAggregator.ts
(1 hunks)packages/toolbox/src/commands/chainlink/addAggregators.ts
(1 hunks)packages/toolbox/src/commands/chainlink/listMissingAggregators.ts
(1 hunks)packages/toolbox/src/commands/transaction/utils.ts
(1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
packages/toolbox/README.md
76-76: No empty links
null
(MD042, no-empty-links)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: build-and-test
- GitHub Check: build-and-test
🔇 Additional comments (4)
packages/toolbox/src/commands/chainlink/listMissingAggregators.ts (1)
26-26
: Updated API endpoint URL in option description.The description now correctly references
https://api.request.finance/currency/list/NAME
instead of the previousrequest.network
endpoint. This change is well aligned with similar updates elsewhere in the codebase.packages/toolbox/src/commands/transaction/utils.ts (1)
44-45
: Updated fetch URL to the new API endpoint.The
getChainConfig
function now fetches data fromhttps://api.request.finance/currency/chains/${chainName}
, which aligns with the new endpoint. The error handling remains intact.packages/toolbox/src/commands/chainlink/addAggregators.ts (1)
42-45
: Updated API endpoint URL in the command builder description.The
list
option description now instructs users to refer tohttps://api.request.finance/currency/list/NAME
, ensuring consistency with the updated documentation across the project.packages/toolbox/src/commands/chainlink/addAggregator.ts (1)
52-56
: Updated list option description with the new API endpoint.The description now correctly specifies that the list must be available at
https://api.request.finance/currency/list/NAME
. This update brings consistency across all command options dealing with currency lists.
Summary by CodeRabbit