Refactor codes and try to improve the quality of code #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 9, 2021 16:04
Kumaravinash9
force-pushed
the
refactor
branch
from
84fe76c to
fd34ec9
Compare
Kumaravinash9
changed the title
|
@csoler Please merge this PR. |
csoler
reviewed
Sep 13, 2021
| // chatMiddleware(message, context); | ||
| addChatMessage(message, chatId); | ||
| } else { | ||
| throw HttpException('You are not the member of the chat Lobby'); |
There was a problem hiding this comment.
when you display a message, it's better to use "chat room" than "chat lobby".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix : #53
Changes Committed
init State. On some phones, it causes a problem.Textfieldwidget withSizedBox.