Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RC_BILLING store #3773

Merged
merged 3 commits into from
Mar 26, 2024
Merged

Add RC_BILLING store #3773

merged 3 commits into from
Mar 26, 2024

Conversation

tonidero
Copy link
Contributor

Description

iOS part of adding RC_BILLING store to the mobile SDKs

tonidero
tonidero commented Mar 22, 2024
View reviewed changes
Sources/Purchasing/EntitlementInfo.swift Outdated
@@ -40,6 +40,9 @@ import Foundation
/// For entitlements granted via the Amazon Store.
@objc(RCAmazon) case amazon = 6

/// For entitlements granted via RC Billing
@objc(RCRCBilling) case rcBilling = 7
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't really sure about the ObjC name, but I didn't want to call it RCBilling thoughts?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haha I guess we kinda backed ourselves into a wall with that one.

I suppose technically RCRCBilling is correct but I'm torn. Like, the purpose of the RC prefix is to prevent collisions, which already happens, so I'm not sure doing RCRC provides much benefit over RCBilling.

@MarkVillacampa @joshdholtz thoughts?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm well... I guess as long as we don't have any other Billing stores in the future, it should be ok 😅. Will rename it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha uh... I do agree that RCBilling is probably the right way to go even though it feels weird because different pattern 🤷‍♂️

@tonidero tonidero marked this pull request as ready for review March 22, 2024 16:35
@tonidero tonidero requested review from a team March 22, 2024 16:35
aboedo
aboedo reviewed Mar 22, 2024
View reviewed changes
Sources/CodableExtensions/Store+Extensions.swift
@@ -63,6 +63,7 @@ private extension Store {
case .promotional: return "promotional"
case .amazon: return "amazon"
case .unknownStore: return nil
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's happening

Sources/Purchasing/EntitlementInfo.swift Outdated
@@ -40,6 +40,9 @@ import Foundation
/// For entitlements granted via the Amazon Store.
@objc(RCAmazon) case amazon = 6

/// For entitlements granted via RC Billing
@objc(RCRCBilling) case rcBilling = 7
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haha I guess we kinda backed ourselves into a wall with that one.

I suppose technically RCRCBilling is correct but I'm torn. Like, the purpose of the RC prefix is to prevent collisions, which already happens, so I'm not sure doing RCRC provides much benefit over RCBilling.

@MarkVillacampa @joshdholtz thoughts?

@tonidero tonidero mentioned this pull request Mar 25, 2024
Merged
1 task
@tonidero tonidero requested a review from aboedo March 25, 2024 10:37
joshdholtz
joshdholtz approved these changes Mar 26, 2024
View reviewed changes
Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tonidero tonidero merged commit bf81b25 into main Mar 26, 2024
24 checks passed
@tonidero tonidero deleted the bil-436-add-rc_billing-store-to-mobile-sdks branch March 26, 2024 10:23
@tonidero tonidero mentioned this pull request Mar 26, 2024
Merged
tonidero added a commit that referenced this pull request Mar 27, 2024
@tonidero
Release/4.39.1 (#3774)
ae2b706 
### Dependency Updates
* Bump fastlane-plugin-revenuecat_internal from `d23de33` to `8d4d9b1`
(#3769) via dependabot[bot] (@dependabot[bot])
### Other Changes
* Add `RC_BILLING` store (#3773) via Toni Rico (@tonidero)
* Add lane to trigger bumps (#3766) via Cesar de la Vega (@vegaro)
tonidero added a commit to RevenueCat/purchases-hybrid-common that referenced this pull request Mar 27, 2024
@tonidero
Add RC_BILLING store (#773)
6689f08 
Depends on RevenueCat/purchases-ios#3773 and
RevenueCat/purchases-android#1657.

Adds the `RC_BILLING` store support to PHC. In android, we don't need to
map it since we use the enum's `name` property.

#### TODO
- [x] Holding until natives have been deployed and updated in PHC.
@Kaspik
Copy link

Kaspik commented Apr 4, 2024

Can we get some info into documentation what rcBilling actually is? Just seeing warnings for not-exhaustive switch and have no idea where to categorize that.

@tonidero
Copy link
Contributor Author

tonidero commented Apr 4, 2024

Can we get some info into documentation what rcBilling actually is? Just seeing warnings for not-exhaustive switch and have no idea where to categorize that.

Hi @Kaspik,

RCBilling is the new web subscription service provided by RC (currently on beta). You can check more information in our blogpost: https://www.revenuecat.com/blog/company/introducing-revenuecat-billing/. So this new store will be returned if a purchase is done through this new web subscription service and using the same account in your mobile apps.

Please, let us know if you have any more questions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshdholtz joshdholtz joshdholtz approved these changes

@aboedo aboedo Awaiting requested review from aboedo

Assignees
No one assigned
Labels
pr:other
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tonidero @Kaspik @joshdholtz @aboedo @vegaro