fix: uniswap adapter patch #315
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fixed an issue which prevented correct path decoding with path of more than 2 pairs - directly decode first and last address in path for gas savings - avoid looping through intermediate pairs for gas savings - remove 1 private method and move addresses decoding back in their calling methods
- added tests for routes involving more than 2 pairs - remove tests for rogue path input as they would be reverted in uniswap router anyway
gabririgo
added
enhancement
- import LibBytes directly intead of from Path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch resolves an issue that prevents correct multi-hop path decoding with routes involving more than 2 pairs and introduces further gas optimizations.