Pin bazel version to 5.2.0 to work around drake#17763 #235
Conversation
There was a problem hiding this comment.
+@svenevs for review.
I don't normally commit to this repo, so let me know if there are procedures I need to be following.
Reviewable status: all discussions resolved, LGTM missing from assignee svenevs, platform LGTM missing (waiting on @svenevs)
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all discussions resolved, platform LGTM missing (waiting on @ggould-tri)
There was a problem hiding this comment.
I don't normally commit to this repo, so let me know if there are procedures I need to be following.
Same, it seems it is the same as drake. drake-ci only needs one approval. +@rpoyner-tri for platform review per schedule please.
Reviewable status: all discussions resolved, LGTM missing from assignee rpoyner-tri, platform LGTM missing (waiting on @rpoyner-tri)
There was a problem hiding this comment.
Hm. Do we want to track RobotLocomotion/drake#17764 and pin 5.1 instead?
Reviewable status: all discussions resolved, LGTM missing from assignee rpoyner-tri, platform LGTM missing (waiting on @rpoyner-tri)
There was a problem hiding this comment.
It would have been using 5.2 prior to today, so this is restoring status quo ante.
IMO, if the ultimate objective is for this to use head bazel as in the past, and we have a brief exception here, then 5.2 is the logical choice as it's both what we did before and also closest to head.
If on the other hand the objective is to get d-e-e to consume a bazel version from drake and we just temporarily don't have the plumbing yet, 5.1.0 makes more sense.
But I'm not sure what the original objective of d-e-e using bazel head was.
Reviewable status: all discussions resolved, LGTM missing from assignee rpoyner-tri, platform LGTM missing (waiting on @rpoyner-tri)
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all discussions resolved, platform LGTM missing (waiting on @ggould-tri)
There was a problem hiding this comment.
Somehow I seem to be marked as a reviewer here? -@ggould-tri ?
Reviewable status: all discussions resolved, platform LGTM missing (waiting on @ggould-tri)
There was a problem hiding this comment.
Reviewable status: all discussions resolved, platform LGTM missing (waiting on @ggould-tri)
There was a problem hiding this comment.
Hm, that didn't work. +@ggould-tri
Reviewable status:
complete! all discussions resolved, platform LGTM from [ggould-tri] (waiting on @ggould-tri)
There was a problem hiding this comment.
Reviewable status:
This reverts commit a4c9bda.
This change is