Revert "Pin bazel version to 5.2.0" #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
jwnimmer-tri
force-pushed
the
revert-235-pin-bazel
branch
2 times, most recently
from
a90aa14
to
fd13317
Compare
This reverts commit a4c9bda, effectively unpinning us to use the latest stable bazel (5.3.1 as of today).
jwnimmer-tri
force-pushed
the
revert-235-pin-bazel
branch
from
fd13317
to
c8c2977
Compare
|
+@rpoyner-tri for both reviews, please. |
rpoyner-tri
approved these changes
Oct 4, 2022
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all discussions resolved, platform LGTM missing (waiting on @jwnimmer-tri)
rpoyner-tri
approved these changes
Oct 4, 2022
There was a problem hiding this comment.
Hm, not clear to me what bits are missing for merge.
Reviewable status: all discussions resolved, platform LGTM missing (waiting on @jwnimmer-tri)
|
The list of known platform reviewers was (very) stale. Fixed now in our reviewable config panel. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit #235, effectively unpinning us to use the latest stable bazel (5.3.1 as of today).
Also (prior to the revert), fix CI scripts to not choke on cleanup of readonly files, to deal with the mess of bazelbuild/bazel#15616.
This change is