workspace: Update sdformat to latest release 8.4.0 #12268
Conversation
jwnimmer-tri
added
priority: low
status: do not merge
status: do not review
and removed
status: do not merge
labels
|
+@EricCousineau-TRI for feature review, please. |
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status: needs at least two assigned reviewers
|
+@soonho-tri for platform review per schedule (tomorrow), please. |
|
@drake-jenkins-bot mac-catalina-clang-bazel-experimental-release please |
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status: 1 unresolved discussion (waiting on @jwnimmer-tri)
tools/workspace/sdformat/repository.bzl, line 10 at r1 (raw file):
# From the following branch: # https://bitbucket.org/osrf/sdformat/commits/branch/default commit = "6bb8c1cc6615" # v8.4.0
nit, can we use sdformat8_8.4.0 here? (found a list of tags from https://bitbucket.org/osrf/sdformat/downloads/?tab=tags)
There was a problem hiding this comment.
Reviewable status:
complete! all discussions resolved, LGTM from assignees soonho-tri(platform),EricCousineau-TRI(platform)
tools/workspace/sdformat/repository.bzl, line 10 at r1 (raw file):
Previously, soonho-tri (Soonho Kong) wrote…
nit, can we use
sdformat8_8.4.0here? (found a list of tags from https://bitbucket.org/osrf/sdformat/downloads/?tab=tags)
OK I will check in the future. My recollection is no.
This change is