framework: Deprecate kAutoSize #13981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In pydrake, remove it immediately. (As of Python 3.6, there is no official support for deprecating attributes; it's new as of 3.7.) This is a breaking change.
jwnimmer-tri
added
priority: low
status: single reviewer ok
|
+@sherm1 for both reviews, please. |
sherm1
reviewed
Sep 1, 2020
There was a problem hiding this comment.
Reviewed 6 of 6 files at r1.
Reviewable status:complete! all discussions resolved, LGTM from assignee sherm1(platform)
rpoyner-tri
added a commit
to rpoyner-tri/drake
that referenced
this pull request
Dec 1, 2020
Deprecated as of: * bullet, freetype2 externals (RobotLocomotion#13986) * drake::systems::kAutoSize (RobotLocomotion#13981) * drake::systems::Subvector empty constructor (RobotLocomotion#13907) * drake::math::Slerp (RobotLocomotion#13810) * drake::systems::Simulator: time jumps warning (RobotLocomotion#13851)
rpoyner-tri
added a commit
to rpoyner-tri/drake
that referenced
this pull request
Dec 1, 2020
Deprecated as of: * bullet, freetype2 externals (RobotLocomotion#13986) * drake::systems::kAutoSize (RobotLocomotion#13981) * drake::systems::Subvector empty constructor (RobotLocomotion#13907) * drake::math::Slerp (RobotLocomotion#13810) * drake::systems::Simulator: time jumps warning (RobotLocomotion#13851)
sammy-tri
pushed a commit
that referenced
this pull request
Dec 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mention of an unimplemented feature is a distraction for users.
In pydrake, remove it immediately. (As of Python 3.6, there is no official support for deprecating attributes; it's new as of 3.7.) This is a breaking change.
Closes #3109.
This change is