pydrake systems: Add missing bindings to ContinuousState, DiscreteValues, VectorBase, and BasicVector #14231
Conversation
|
@RussTedrake for feature review |
There was a problem hiding this comment.
awesome. thanks! and looks perfect to my eyes.
+@sammy-tri for platform review.
Reviewed 4 of 4 files at r1.
Reviewable status: LGTM missing from assignee sammy-tri(platform) (waiting on @sammy-tri)
|
I just realized that the way I wrote the |
There was a problem hiding this comment.
operator[] question before merging?
Reviewed 4 of 4 files at r1.
Reviewable status:complete! all discussions resolved, LGTM from assignees sammy-tri(platform),RussTedrake(platform)
|
Yes, let's wait on merge because I just found a fix to the problem. Adding tests and will post shortly. |
There was a problem hiding this comment.
+(status: do not merge) adding Do Not Merge just to make sure I don't do it accidentally while you're updating.
Reviewable status: labeled "do not merge"
mpetersen94
force-pushed
the
bind/systems
branch
from
26439fc
to
8fdf09c
Compare
There was a problem hiding this comment.
Ok. Ready for review and merge if everyone is happy. I also added bidings for DiscreteValues while it was compiling.
Reviewable status: labeled "do not merge" (waiting on @RussTedrake and @sammy-tri)
mpetersen94
changed the title
There was a problem hiding this comment.
-(status: do not merge) Just one question about a doc comment.
Reviewed 5 of 5 files at r2.
Reviewable status: 1 unresolved discussion, labeled "do not merge" (waiting on @mpetersen94)
systems/framework/discrete_values.h, line 60 at r2 (raw file):
/// Constructs a %DiscreteValues that owns the underlying @p data. Every entry /// must be non-null. /// @exclude_from_pydrake_mkdoc{This overload is not bound in pydrake.}
Is this also true for the overload directly above? (1arg data)
There was a problem hiding this comment.
Reviewed 5 of 5 files at r2.
Reviewable status: 1 unresolved discussion (waiting on @mpetersen94)
mpetersen94
force-pushed
the
bind/systems
branch
from
8fdf09c
to
d38ba57
Compare
There was a problem hiding this comment.
Reviewable status: 1 unresolved discussion (waiting on @RussTedrake and @sammy-tri)
systems/framework/discrete_values.h, line 60 at r2 (raw file):
Previously, sammy-tri (Sam Creasey) wrote…
Is this also true for the overload directly above? (1arg
data)
Done. Initially I tried binding the other which caused some seg faults. Binding this one and excluding the other works better.
There was a problem hiding this comment.
Reviewed 3 of 3 files at r3.
Reviewable status:
Addresses two check boxes for #14223
This change is