Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lcmtypes: Remove stray deprecation notice #14539

Merged

Conversation

jwnimmer-tri
Copy link
Collaborator

@jwnimmer-tri jwnimmer-tri commented Jan 16, 2021

This snuck in during #14372 after it was rebased over #14377. Previously the plan was to deprecate this message, but after the rewrite we decided to keep it. The BUILD.bazel file was correct (no deprecation) but the stale comments were overlooked.


This change is Reviewable

This snuck in during 0da1f83 after it was rebased over bf2d26e.

Previously the plan was to deprecate this message, but after the
rewrite we decided to keep it.  The BUILD.bazel file was correct
but the stale comments were overlooked.
@jwnimmer-tri jwnimmer-tri added priority: low status: single reviewer ok https://drake.mit.edu/reviewable.html labels Jan 16, 2021
@jwnimmer-tri
Copy link
Collaborator Author

+@avalenzu for feature review, please.

Copy link
Contributor

@avalenzu avalenzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1.
Reviewable status: needs platform reviewer assigned

@jwnimmer-tri
Copy link
Collaborator Author

+@EricCousineau-TRI for platform review atop #14372, please.

Copy link
Contributor

@EricCousineau-TRI EricCousineau-TRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all discussions resolved, LGTM from assignees avalenzu,EricCousineau-TRI(platform) (waiting on @EricCousineau-TRI)

@EricCousineau-TRI EricCousineau-TRI merged commit 4a593df into RobotLocomotion:master Jan 21, 2021
@jwnimmer-tri jwnimmer-tri deleted the lcmtypes-undeprecate branch January 21, 2021 17:30
josephsnyder pushed a commit to EricCousineau-TRI/drake that referenced this pull request Mar 16, 2021
This snuck in during 0da1f83 after it was rebased over bf2d26e.

Previously the plan was to deprecate this message, but after the
rewrite we decided to keep it.  The BUILD.bazel file was correct
but the stale comments were overlooked.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: low status: single reviewer ok https://drake.mit.edu/reviewable.html
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants