Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unnamed namespace to prevent kcov issue #339 #17835

Merged
merged 1 commit into from Sep 4, 2022
Merged

Add unnamed namespace to prevent kcov issue #339 #17835

merged 1 commit into from Sep 4, 2022

Conversation

xuchenhan-tri
Copy link
Contributor

@xuchenhan-tri xuchenhan-tri commented Sep 4, 2022 •
edited by sherm1

This change is Reviewable

@xuchenhan-tri xuchenhan-tri added status: single reviewer ok https://drake.mit.edu/reviewable.html component: build system Bazel, CMake, dependencies, memory checkers, linters release notes: none This pull request should not be mentioned in the release notes labels Sep 4, 2022
@xuchenhan-tri
Copy link
Contributor Author

@drake-jenkins-bot linux-focal-clang-bazel-experimental-coverage please.

@xuchenhan-tri xuchenhan-tri marked this pull request as ready for review September 4, 2022 19:11
RussTedrake
RussTedrake reviewed Sep 4, 2022
View reviewed changes
Copy link
Contributor

@RussTedrake RussTedrake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: x2 (the change is certainly good... though I admit I don't know why it would make kcov fail).

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: needs platform reviewer assigned, needs at least one assigned reviewer (waiting on @xuchenhan-tri)

xuchenhan-tri
xuchenhan-tri commented Sep 4, 2022
View reviewed changes
Copy link
Contributor Author

@xuchenhan-tri xuchenhan-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a known kcov issue that we run into occasionally: see SimonKagstrom/kcov#339.

Reviewable status: needs platform reviewer assigned, needs at least one assigned reviewer (waiting on @xuchenhan-tri)

@xuchenhan-tri
Copy link
Contributor Author

+@RussTedrake for both reviews.

@xuchenhan-tri xuchenhan-tri merged commit 215ee54 into RobotLocomotion:master Sep 4, 2022
@xuchenhan-tri xuchenhan-tri deleted the kcov-fix branch September 4, 2022 20:54
@jwnimmer-tri jwnimmer-tri mentioned this pull request Sep 26, 2022
Closed
jwnimmer-tri added a commit to jwnimmer-tri/drake that referenced this pull request Oct 18, 2022
@jwnimmer-tri
Revert "Add unnamed namespace to prevent kcov issue RobotLocomotion#339…
e030086 
… (RobotLocomotion#17835)"

This reverts commit 215ee54.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RussTedrake RussTedrake RussTedrake left review comments

Assignees

@RussTedrake RussTedrake

Labels
component: build system Bazel, CMake, dependencies, memory checkers, linters release notes: none This pull request should not be mentioned in the release notes status: single reviewer ok https://drake.mit.edu/reviewable.html
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xuchenhan-tri @RussTedrake