[IMPROVE] Move app list install logic to app menu #27056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved the install/buy/subscribe logic from the CTA buttons that existed in the app list to the app menu. Now the user can install apps by clicking in the kebab menu in the right of the app list entry. Also solved a little undefindd bug happening with the app permissions modal.
Codecov Report
@@ Coverage Diff @@
## develop #27056 +/- ##
===========================================
+ Coverage 40.93% 41.72% +0.78%
===========================================
Files 851 826 -25
Lines 18700 18233 -467
Branches 2050 1988 -62
===========================================
- Hits 7655 7607 -48
+ Misses 10760 10340 -420
- Partials 285 286 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
…hat/Rocket.Chat into improve/marketplace-apps-buttons
juliajforesti
requested changes
Nov 8, 2022
Applied DRY to two helper functions of both AppStatus and AppMenu in order to improve maintainability.
juliajforesti
approved these changes
Nov 9, 2022
dionisio-bot
bot
added
stat: ready to merge
bkrith
pushed a commit
to bkrith/Rocket.Chat
that referenced
this pull request
Nov 12, 2022
MartinSchoeler
pushed a commit
that referenced
this pull request
Nov 18, 2022
MartinSchoeler
pushed a commit
that referenced
this pull request
Nov 28, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Jira task: MKP-136
Moved the install/buy/subscribe logic from the CTA buttons that existed in the app list to the app menu. Now the user can install apps by clicking in the kebab menu in the right of the app list entry. Also solved a little undefined bug happening in the app permissions modal.
Demo gif:
Issue(s)
Steps to test or reproduce
Further comments