Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RBS #1054

Merged
merged 8 commits into from
Mar 18, 2024
Merged

RBS #1054

merged 8 commits into from
Mar 18, 2024

Conversation

DalenW
Copy link
Contributor

@DalenW DalenW commented May 14, 2023

This adds RBS files for the gem. It's something I needed for a project of mine, but I might as well offer the PR here too. I didn't change any of the files under lib (except for one spelling correction), and most of the types I was unsure about I left as untyped.

@semmons99
Copy link
Member

would you please ensure all files have standard unix line endings. happy to merge afterward

@DalenW
Copy link
Contributor Author

DalenW commented Oct 3, 2023

I doubled checked all the files in the PR, they're all UTF-8 and end in LF, which is standard. Which files are giving you trouble?

@semmons99
Copy link
Member

my fault for not getting back sooner. if you check the RBS files, github notes all of them are missing unix line endings.

please, also resolve merge conflicts. happy to merge afterward.

@semmons99 semmons99 merged commit 73b84b5 into RubyMoney:main Mar 18, 2024
4 checks passed
@semmons99
Copy link
Member

ty!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants