Skip to content

Fix compile error with VS 2013 #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 8, 2013
Merged

Fix compile error with VS 2013 #29

merged 1 commit into from
Sep 8, 2013

Conversation

ethan-tqa
Copy link
Contributor

According to this http://msdn.microsoft.com/en-us/library/vstudio/bb531344(v=vs.120).aspx, must be included to use std::min() and std::max()

@dougbinks
Copy link
Collaborator

Thanks, that's a good find.

I'll be adding VS 2013 to my test suite when it's officially released, so should hopefully catch these issues in future.

Note that algorithm can be included on all platforms for std::min and std::max, so I'll likely move to removing the #if once I get the chance to test this change on those platforms. For now I'll pull this.

dougbinks added a commit that referenced this pull request Sep 8, 2013
Fix compile error with VS 2013
@dougbinks dougbinks merged commit cc66fd4 into RuntimeCompiledCPlusPlus:master Sep 8, 2013
@ethan-tqa
Copy link
Contributor Author

It is unlikely that VS 2013 will be released in the next few months, so I think you can actually grab VS 2013 Preview to test.

@dougbinks
Copy link
Collaborator

I don't have a spare system or image ready to install VS Preview on, and from previous experience I know installing to my main system can mean a full re-install later, so I'll pass on the preview.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants