[FIX] ProjectBuilder now can be executed in parallel #669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d3xter666
force-pushed
the
fix-parallel-project-builder-exec
branch
from
5bef1b3 to
3076e97
Compare
RandomByte
approved these changes
Oct 19, 2023
d3xter666
added a commit
to UI5/cli
that referenced
this pull request
Sep 25, 2025
…5-project#669) Fixes: #887 ProjectBuilder was using a singleton of the logger module. Basically, the logger was constructed only once, during module evaluation, but used throughout the whole module. The tricky part is that the `ProjectBuilder`'s logger has this `setProjects()` method that acts as an allow list of the projects being built. As the logger used to be a singleton within this module/class and the async behaviour of the whole module, calling `setProject()` was polluting the internal `projects` property. With this fix, every `ProjectBuilder` instance has its own`BuildLogger` instance that solves the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: UI5/cli#887
ProjectBuilder was using a singleton of the logger module. Basically, the logger was constructed only once, during module evaluation, but used throughout the whole module.
The tricky part is that the
ProjectBuilder's logger has thissetProjects()method that acts as an allow list of the projects being built. As the logger used to be a singleton within this module/class and the async behaviour of the whole module, callingsetProject()was polluting the internalprojectsproperty.With this fix, every
ProjectBuilderinstance has its ownBuildLoggerinstance that solves the issue.